> On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote: > > sentry-dist/pom.xml > > Lines 66 (patched) > > <https://reviews.apache.org/r/69351/diff/3/?file=2108316#file2108316line66> > > > > You did an exclusion of * above, why not do it again here?
It didnt work. I ended up for some reason needing to exclude them manually. > On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote: > > sentry-dist/src/main/assembly/bin.xml > > Lines 49 (patched) > > <https://reviews.apache.org/r/69351/diff/3/?file=2108317#file2108317line49> > > > > Why twice? Because im repetative. Also im repetative. > On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote: > > sentry-provider/sentry-provider-db/pom.xml > > Lines 179 (patched) > > <https://reviews.apache.org/r/69351/diff/3/?file=2108318#file2108318line179> > > > > Is there a differnence between the long list of exclusions, * or > > jetty*? Mainly asking for consistency's sake. This worked for the local dependencies for provider-db. sentry-dist was having issues which required the full list. > On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote: > > sentry-service/sentry-service-server/pom.xml > > Line 235 (original) > > <https://reviews.apache.org/r/69351/diff/3/?file=2108328#file2108328line240> > > > > This was removed, is it still needed elsewhere? It not needed anymore. It was being used to change the version on the index html in the source. But the same thing can be done with a resources filter. > On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote: > > sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/SentryWebServer.java > > Lines 1 (patched) > > <https://reviews.apache.org/r/69351/diff/3/?file=2108346#file2108346line1> > > > > This file has been moved, can we have git mark it as so instead of a > > new file. I think the changes made to the file were significant enough that it would not mark it as moved. > On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote: > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap-theme.min.css > > Lines 1 (patched) > > <https://reviews.apache.org/r/69351/diff/3/?file=2108349#file2108349line1> > > > > Is it worth it to add the bootstrap version info to either the file > > name or in a comment? Changed > On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote: > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap.min.css > > Lines 1 (patched) > > <https://reviews.apache.org/r/69351/diff/3/?file=2108350#file2108350line1> > > > > Same comment as above about bootstrap version. Changed > On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote: > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap.js > > Lines 32 (patched) > > <https://reviews.apache.org/r/69351/diff/3/?file=2108356#file2108356line32> > > > > Why do we have 2 different copyrights? Is this file under the MIT > > license? This is a direct copy of the file. It how they copyrighted it. > On Nov. 20, 2018, 12:04 p.m., Steve Moist wrote: > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap.js > > Lines 92 (patched) > > <https://reviews.apache.org/r/69351/diff/3/?file=2108356#file2108356line92> > > > > Why is there another one here? This is a direct copy of the file. It how they copyrighted it. - Brian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/#review210669 ----------------------------------------------------------- On Nov. 15, 2018, 2:05 p.m., Brian Towles wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69351/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2018, 2:05 p.m.) > > > Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na > Li, Steve Moist, and Sergio Pena. > > > Bugs: SENTRY-2458 > https://issues.apache.org/jira/browse/SENTRY-2458 > > > Repository: sentry > > > Description > ------- > > SENTRY-2458: Split web service from server service modules > > In order to additional modules to be added to Sentry there needs to be a > separation of some of the features used by service-server into other modules. > > This will allow the web server to be pulled out from the base server and > allow for additional modules to be able to add web services and functionality > to the web interface without depending up the whole server module. > > It will use the SPI to dynamically include servlets and content from other > modules. > > It creates a sentry-service-providers to allow for Server and sub modules SPI > providers to be defined externally and not depended on directly. > > > Diffs > ----- > > pom.xml 46ca38e9a > sentry-dist/pom.xml 62558d2e0 > sentry-dist/src/main/assembly/bin.xml 986530c55 > sentry-provider/sentry-provider-db/pom.xml df569474a > sentry-service/pom.xml e653189eb > sentry-service/sentry-service-providers/pom.xml PRE-CREATION > > sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java > PRE-CREATION > > sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java > PRE-CREATION > > sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProvider.java > PRE-CREATION > > sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceProviderFactory.java > PRE-CREATION > > sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/SentryWebServiceSpi.java > PRE-CREATION > > sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java > PRE-CREATION > > sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi > PRE-CREATION > sentry-service/sentry-service-server/pom.xml 44540ad5d > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java > 862548745 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java > af81d6fce > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java > 8da35f10f > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java > PRE-CREATION > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java > 5dc6cd6c4 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java > 23121ecf5 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java > PRE-CREATION > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java > befe6c3ed > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java > b3a4934df > > sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.SentryWebServiceProviderFactory > PRE-CREATION > > sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css > c31428b07 > sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css > a553c4f5e > sentry-service/sentry-service-server/src/main/webapp/css/sentry.css > sentry-service/sentry-service-server/src/main/webapp/sentry.png > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithoutSecurity.java > 6e741e895 > sentry-service/sentry-service-web/pom.xml PRE-CREATION > > sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/DefaultWebServicesProvider.java > PRE-CREATION > > sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/SentryWebServer.java > PRE-CREATION > > sentry-service/sentry-service-web/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.SentryWebServiceProviderFactory > PRE-CREATION > sentry-service/sentry-service-web/src/main/webapp/index.html PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap-theme.min.css > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap.min.css > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.eot > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.svg > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.ttf > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff2 > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap.js > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap.min.js > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/npm.js > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/css/materialdesignicons.min.css > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.eot > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.svg > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.ttf > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff2 > PRE-CREATION > > > Diff: https://reviews.apache.org/r/69351/diff/3/ > > > Testing > ------- > > Running with web and unit tests > > > Thanks, > > Brian Towles > >
