> On Nov. 26, 2018, 3:22 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java > > Lines 20 (patched) > > <https://reviews.apache.org/r/69351/diff/4/?file=2109307#file2109307line22> > > > > or you should move it from under "sentry-service/sentry-service-server" > > to "sentry-service/sentry-service-web"
This is the config for the whole service not just the thrift server part - Brian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69351/#review210878 ----------------------------------------------------------- On Nov. 26, 2018, 9:32 p.m., Brian Towles wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69351/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2018, 9:32 p.m.) > > > Review request for sentry, Anthony Young-Garner, kalyan kumar kalvagadda, Na > Li, Steve Moist, and Sergio Pena. > > > Bugs: SENTRY-2458 > https://issues.apache.org/jira/browse/SENTRY-2458 > > > Repository: sentry > > > Description > ------- > > SENTRY-2458: Split web service from server service modules > > In order to additional modules to be added to Sentry there needs to be a > separation of some of the features used by service-server into other modules. > > This will allow the web server to be pulled out from the base server and > allow for additional modules to be able to add web services and functionality > to the web interface without depending up the whole server module. > > It will use the SPI to dynamically include servlets and content from other > modules. > > It creates a sentry-service-providers to allow for Server and sub modules SPI > providers to be defined externally and not depended on directly. > > > Diffs > ----- > > pom.xml 46ca38e9a > sentry-dist/pom.xml 62558d2e0 > sentry-dist/src/main/assembly/bin.xml 986530c55 > sentry-provider/sentry-provider-db/pom.xml df569474a > sentry-service/pom.xml e653189eb > sentry-service/sentry-service-providers/pom.xml PRE-CREATION > > sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/AttributeDesc.java > PRE-CREATION > > sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/FilterDesc.java > PRE-CREATION > > sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/ServletDesc.java > PRE-CREATION > > sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProvider.java > PRE-CREATION > > sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceProviderFactory.java > PRE-CREATION > > sentry-service/sentry-service-providers/src/main/java/org/apache/sentry/server/provider/webservice/WebServiceSpi.java > PRE-CREATION > > sentry-service/sentry-service-providers/src/main/resources/META-INF/services/org.apache.sentry.spi.Spi > PRE-CREATION > sentry-service/sentry-service-server/pom.xml 44540ad5d > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java > 862548745 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java > af81d6fce > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java > 8da35f10f > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/RolesServlet.java > PRE-CREATION > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java > 5dc6cd6c4 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java > 23121ecf5 > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryServiceWebServiceProvider.java > PRE-CREATION > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java > befe6c3ed > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java > b3a4934df > > sentry-service/sentry-service-server/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.WebServiceProviderFactory > PRE-CREATION > > sentry-service/sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css > c31428b07 > sentry-service/sentry-service-server/src/main/webapp/css/bootstrap.min.css > a553c4f5e > sentry-service/sentry-service-server/src/main/webapp/css/sentry.css > sentry-service/sentry-service-server/src/main/webapp/sentry.png > > sentry-service/sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithoutSecurity.java > 6e741e895 > sentry-service/sentry-service-web/pom.xml PRE-CREATION > > sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/DefaultWebServicesProvider.java > PRE-CREATION > > sentry-service/sentry-service-web/src/main/java/org/apache/sentry/service/web/SentryWebServer.java > PRE-CREATION > > sentry-service/sentry-service-web/src/main/resources/META-INF/services/org.apache.sentry.server.provider.webservice.WebServiceProviderFactory > PRE-CREATION > sentry-service/sentry-service-web/src/main/webapp/index.html PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap-3.3.7.min.css > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/css/bootstrap-theme-3.3.7.min.css > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.eot > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.svg > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.ttf > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff2 > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap-3.3.7.js > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/bootstrap-3.3.7.min.js > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/js/npm.js > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/css/materialdesignicons.min.css > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.eot > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.svg > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.ttf > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff > PRE-CREATION > > sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff2 > PRE-CREATION > > > Diff: https://reviews.apache.org/r/69351/diff/5/ > > > Testing > ------- > > Running with web and unit tests > > > Thanks, > > Brian Towles > >
