----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69530/#review211145 -----------------------------------------------------------
sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Line 3454 (original), 3451 (patched) <https://reviews.apache.org/r/69530/#comment296073> Why do you remove the input of "currentSnapshotID"? There could be multiple snapshots, and we need to make sure to remove the one in the latest Snapsho sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Line 3455 (original), 3452 (patched) <https://reviews.apache.org/r/69530/#comment296076> if it possible that there are multiple instances in table AUTHZ_PATH, they are of the same value of "PATH_NAME", but belong to different "authzObj"? If that is the case, you delect more entries than you need to. Basically, you delete all entries matching input "paths" regardless the value of "authzObj". That is not right. sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Line 3551 (original), 3539 (patched) <https://reviews.apache.org/r/69530/#comment296074> why do you remove input "currentSnapshotID" sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java Lines 3739 (patched) <https://reviews.apache.org/r/69530/#comment296075> path is a collection. Can you change the input parameter name to reflect that? - Na Li On Dec. 10, 2018, 2:11 a.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69530/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2018, 2:11 a.m.) > > > Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, Na Li, and > Sergio Pena. > > > Bugs: SENTRY-2476 > https://issues.apache.org/jira/browse/SENTRY-2476 > > > Repository: sentry > > > Description > ------- > > Right now when we process a drop partition event, we fetch each path object > for paths_mapping object then find the one we want to delete and then delete > it. We should avoid fetching all objects and directly delete the path that > needs to be deleted > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > e2d6c85ac > > > Diff: https://reviews.apache.org/r/69530/diff/3/ > > > Testing > ------- > > $ mvn -f sentry-service/sentry-service-server/pom.xml test > -Dtest=TestNotificationProcessor > > > Thanks, > > Arjun Mishra > >
