> On Dec. 10, 2018, 4:57 p.m., Na Li wrote: > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 3455 (original), 3452 (patched) > > <https://reviews.apache.org/r/69530/diff/3/?file=2112732#file2112732line3455> > > > > if it possible that there are multiple instances in table AUTHZ_PATH, > > they are of the same value of "PATH_NAME", but belong to different > > "authzObj"? > > > > If that is the case, you delect more entries than you need to. > > Basically, you delete all entries matching input "paths" regardless the > > value of "authzObj". That is not right.
That would be the case with current scenario too. If you had 2 objects "tbl1", and "tbl2" mapped to a single path "/user/hive/warehouse/tbl", if we delete tbl1, we also delete the path "/user/hive/warehouse/tbl". Let me run a test case for it - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69530/#review211145 ----------------------------------------------------------- On Dec. 10, 2018, 2:11 a.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69530/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2018, 2:11 a.m.) > > > Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, Na Li, and > Sergio Pena. > > > Bugs: SENTRY-2476 > https://issues.apache.org/jira/browse/SENTRY-2476 > > > Repository: sentry > > > Description > ------- > > Right now when we process a drop partition event, we fetch each path object > for paths_mapping object then find the one we want to delete and then delete > it. We should avoid fetching all objects and directly delete the path that > needs to be deleted > > > Diffs > ----- > > > sentry-service/sentry-service-server/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > e2d6c85ac > > > Diff: https://reviews.apache.org/r/69530/diff/3/ > > > Testing > ------- > > $ mvn -f sentry-service/sentry-service-server/pom.xml test > -Dtest=TestNotificationProcessor > > > Thanks, > > Arjun Mishra > >
