----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14070/#review26021 -----------------------------------------------------------
sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/UnmanagedHiveServer.java <https://reviews.apache.org/r/14070/#comment50799> Any reason we don't want to user "hivePrincipal" and "kerberosRealm"? sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/UnmanagedHiveServer.java <https://reviews.apache.org/r/14070/#comment50802> equalsIgnoresCase sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/UnmanagedHiveServer.java <https://reviews.apache.org/r/14070/#comment50803> public static final driverName? sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/UnmanagedHiveServer.java <https://reviews.apache.org/r/14070/#comment50805> While we should throw an exception, we shouldn't shut down the JVM. sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/UnmanagedHiveServer.java <https://reviews.apache.org/r/14070/#comment50808> Can you explain why this is commented out? sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/UnmanagedHiveServer.java <https://reviews.apache.org/r/14070/#comment50806> Why is this method returning null? sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/UnmanagedHiveServer.java <https://reviews.apache.org/r/14070/#comment50807> equalsIgnoreCase? Please see my comments. - Shreepadma Venugopalan On Sept. 10, 2013, 9:36 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14070/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2013, 9:36 p.m.) > > > Review request for sentry, Prasad Mujumdar and Shreepadma Venugopalan. > > > Repository: sentry > > > Description > ------- > > This is required as we need to authenticate before a connection is created > when using UnmanagedHiveServer > > > Diffs > ----- > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/Context.java 30d1aaa > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/AbstractHiveServer.java > 0c2fbc3 > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/EmbeddedHiveServer.java > 48c112c > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/HiveServer.java > ce4b3e8 > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/HiveServerFactory.java > af3344e > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/UnmanagedHiveServer.java > 288d2f7 > > Diff: https://reviews.apache.org/r/14070/diff/ > > > Testing > ------- > > All tests pass > > > Thanks, > > Sravya Tirukkovalur > >
