----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14070/#review26024 -----------------------------------------------------------
sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/UnmanagedHiveServer.java <https://reviews.apache.org/r/14070/#comment50809> Just to keep it short. But now as I think of it more, using "hive.principal" format would be consistent? sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/UnmanagedHiveServer.java <https://reviews.apache.org/r/14070/#comment50810> Changing it to equalsIgnoresCase sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/UnmanagedHiveServer.java <https://reviews.apache.org/r/14070/#comment50820> Will change it. Thanks! sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/UnmanagedHiveServer.java <https://reviews.apache.org/r/14070/#comment50821> We can actually get rid of this check, I see that this check is being made in the HiveServerFactory anyways? sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/UnmanagedHiveServer.java <https://reviews.apache.org/r/14070/#comment50822> Will fix it. Thanks! sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/UnmanagedHiveServer.java <https://reviews.apache.org/r/14070/#comment50818> Removed the comment. Basically when using UnmanagedHiveServer, hive service is started beforehand. sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/UnmanagedHiveServer.java <https://reviews.apache.org/r/14070/#comment50819> This method is not implemented yet in UnmanagedHiveServer. Looks like its only used for getting the hive.warehouse.dir and scratch.dir. Would it be good enough to support these two properties for now? sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/UnmanagedHiveServer.java <https://reviews.apache.org/r/14070/#comment50823> Will change it. - Sravya Tirukkovalur On Sept. 10, 2013, 9:36 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14070/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2013, 9:36 p.m.) > > > Review request for sentry, Prasad Mujumdar and Shreepadma Venugopalan. > > > Repository: sentry > > > Description > ------- > > This is required as we need to authenticate before a connection is created > when using UnmanagedHiveServer > > > Diffs > ----- > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/Context.java 30d1aaa > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/AbstractHiveServer.java > 0c2fbc3 > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/EmbeddedHiveServer.java > 48c112c > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/HiveServer.java > ce4b3e8 > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/HiveServerFactory.java > af3344e > > sentry-tests/src/test/java/org/apache/sentry/tests/e2e/hiveserver/UnmanagedHiveServer.java > 288d2f7 > > Diff: https://reviews.apache.org/r/14070/diff/ > > > Testing > ------- > > All tests pass > > > Thanks, > > Sravya Tirukkovalur > >
