I took a look. Good: - md5 and sha match the source tarball - issue around including libs/jars seems fixed from last RC
Issues/Questions: - NOTICE says "Copyright 2013 The Apache Software Foundation" -- should we update the year? - I tried to verify that the git tag matches the released bits unsuccessfully. I'm not 100% sure how to do this, if anyone has any pointers please let me know. What I did was: 1. checkout the tag 2. build the archive: "git archive --format=tar --prefix=apache-sentry-1.3.0-incubating-src/ HEAD | gzip > apache-sentry-1.3.0-incubating.tar.gz" 3. compare the checksum with the release source tarball And the checksum didn't match up. I notice there are some files in the src tarball that aren't in git -- maybe that is the issue? These are: ./sentry-dist/sentry-dist.iml ./sentry-provider/sentry-provider-file/sentry-provider-file.iml ./sentry-provider/sentry-provider.iml ./sentry-provider/sentry-provider-common/sentry-provider-common.iml ... On Mon, Apr 21, 2014 at 11:31 AM, Joe Brockmeier <[email protected]> wrote: > On Mon, Apr 21, 2014, at 12:09 PM, Ramachandran, Karthik wrote: > > Anyone else have a chance to take a look at this? > > Sorry - this came out during Red Hat Summit, and I was just a wee bit > busy with that... and then holiday weekend. Will try to look at this > tonight. > > Best, > > jzb > -- > Joe Brockmeier > [email protected] > Twitter: @jzb > http://www.dissociatedpress.net/ >
