I think Greg is right. It mostly looks good however there are a number of significant differences between what's in the rc and what's in the tag. Here's the diff output btw the untar'd rc and what's in the tag in git (mostly iml files, but also some directories, e.g. sentry-provider-db).
I'm -1 at the moment. here's the output: phunt@valhalla:~/s$ diff -r incubator-sentry/. apache-sentry-1.3.0-incubating-src/. Only in apache-sentry-1.3.0-incubating-src/./sentry-binding/sentry-binding-hive: sentry-binding-hive.iml Only in apache-sentry-1.3.0-incubating-src/./sentry-binding: sentry-binding.iml Only in apache-sentry-1.3.0-incubating-src/./sentry-binding/sentry-binding-solr: sentry-binding-solr.iml Only in apache-sentry-1.3.0-incubating-src/./sentry-core/sentry-core-common: sentry-core-common.iml Only in apache-sentry-1.3.0-incubating-src/./sentry-core: sentry-core.iml Only in apache-sentry-1.3.0-incubating-src/./sentry-core/sentry-core-model-db: sentry-core-model-db.iml Only in apache-sentry-1.3.0-incubating-src/./sentry-core/sentry-core-model-search: sentry-core-model-search.iml Only in apache-sentry-1.3.0-incubating-src/./sentry-dist: sentry-dist.iml Only in apache-sentry-1.3.0-incubating-src/./sentry-policy/sentry-policy-common: sentry-policy-common.iml Only in apache-sentry-1.3.0-incubating-src/./sentry-policy/sentry-policy-db: sentry-policy-db.iml Only in apache-sentry-1.3.0-incubating-src/./sentry-policy: sentry-policy.iml Only in apache-sentry-1.3.0-incubating-src/./sentry-policy/sentry-policy-search: sentry-policy-search.iml Only in apache-sentry-1.3.0-incubating-src/./sentry-provider/sentry-provider-common: sentry-provider-common.iml Only in apache-sentry-1.3.0-incubating-src/./sentry-provider: sentry-provider-db Only in apache-sentry-1.3.0-incubating-src/./sentry-provider/sentry-provider-file: sentry-provider-file.iml Only in apache-sentry-1.3.0-incubating-src/./sentry-provider: sentry-provider.iml Only in apache-sentry-1.3.0-incubating-src/./sentry-tests/sentry-tests-hive: derby.log Only in apache-sentry-1.3.0-incubating-src/./sentry-tests/sentry-tests-hive: sentry-tests-hive.iml Only in apache-sentry-1.3.0-incubating-src/./sentry-tests/sentry-tests-hive: TempStatsStore Only in apache-sentry-1.3.0-incubating-src/./sentry-tests: sentry-tests.iml Only in apache-sentry-1.3.0-incubating-src/./sentry-tests/sentry-tests-solr: sentry-tests-solr.iml On Mon, Apr 21, 2014 at 12:57 PM, Gregory Chanan <[email protected]> wrote: > I took a look. > > Good: > - md5 and sha match the source tarball > - issue around including libs/jars seems fixed from last RC > > Issues/Questions: > - NOTICE says "Copyright 2013 The Apache Software Foundation" -- should we > update the year? > - I tried to verify that the git tag matches the released bits > unsuccessfully. I'm not 100% sure how to do this, if anyone has any > pointers please let me know. What I did was: > 1. checkout the tag > 2. build the archive: "git archive --format=tar > --prefix=apache-sentry-1.3.0-incubating-src/ HEAD | gzip > > apache-sentry-1.3.0-incubating.tar.gz" > 3. compare the checksum with the release source tarball > And the checksum didn't match up. I notice there are some files in the src > tarball that aren't in git -- maybe that is the issue? These are: > ./sentry-dist/sentry-dist.iml > ./sentry-provider/sentry-provider-file/sentry-provider-file.iml > ./sentry-provider/sentry-provider.iml > ./sentry-provider/sentry-provider-common/sentry-provider-common.iml > ... > > > > On Mon, Apr 21, 2014 at 11:31 AM, Joe Brockmeier <[email protected]> wrote: > >> On Mon, Apr 21, 2014, at 12:09 PM, Ramachandran, Karthik wrote: >> > Anyone else have a chance to take a look at this? >> >> Sorry - this came out during Red Hat Summit, and I was just a wee bit >> busy with that... and then holiday weekend. Will try to look at this >> tonight. >> >> Best, >> >> jzb >> -- >> Joe Brockmeier >> [email protected] >> Twitter: @jzb >> http://www.dissociatedpress.net/ >>
