----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22412/#review45231 -----------------------------------------------------------
Ship it! Nice, thank you for working on this one Prasad! sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBinding.java <https://reviews.apache.org/r/22412/#comment79957> I think that we should create a separate test case for this one? Let's do a separate JIRA for that. Jarcec - Jarek Cecho On June 10, 2014, 8:51 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22412/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 8:51 a.m.) > > > Review request for sentry. > > > Bugs: SENTRY-277 > https://issues.apache.org/jira/browse/SENTRY-277 > > > Repository: sentry > > > Description > ------- > > Basic Pig+HCat test for Metastore auth plugin. > > > Diffs > ----- > > pom.xml 564a2ad > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBinding.java > 2737793 > sentry-tests/sentry-tests-hive/pom.xml 03802a3 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/Context.java > 83fe397 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java > 2e70b14 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetaStoreWithPigHCat.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/22412/diff/ > > > Testing > ------- > > > Thanks, > > Prasad Mujumdar > >
