> On June 10, 2014, 3:06 p.m., Sravya Tirukkovalur wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBinding.java, > > line 256 > > <https://reviews.apache.org/r/22412/diff/1/?file=606412#file606412line256> > > > > if (!partitionLocation.startsWith(tableLocation+ "/")) ?
Good catch! will fix it as part of SENTRY-284. Added a note on that ticket. > On June 10, 2014, 3:06 p.m., Sravya Tirukkovalur wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java, > > line 164 > > <https://reviews.apache.org/r/22412/diff/1/?file=606415#file606415line164> > > > > we are not using the username? right, it can be removed. - Prasad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22412/#review45233 ----------------------------------------------------------- On June 10, 2014, 8:51 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22412/ > ----------------------------------------------------------- > > (Updated June 10, 2014, 8:51 a.m.) > > > Review request for sentry. > > > Bugs: SENTRY-277 > https://issues.apache.org/jira/browse/SENTRY-277 > > > Repository: sentry > > > Description > ------- > > Basic Pig+HCat test for Metastore auth plugin. > > > Diffs > ----- > > pom.xml 564a2ad > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/MetastoreAuthzBinding.java > 2737793 > sentry-tests/sentry-tests-hive/pom.xml 03802a3 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/Context.java > 83fe397 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java > 2e70b14 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetaStoreWithPigHCat.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/22412/diff/ > > > Testing > ------- > > > Thanks, > > Prasad Mujumdar > >
