----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22550/#review45632 -----------------------------------------------------------
It look good !! Just a few minor comments from my side.. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java <https://reviews.apache.org/r/22550/#comment80526> Does this really delete the actual Privilege row from the table ? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java <https://reviews.apache.org/r/22550/#comment80527> Is it possible to iterate of the roleset here and do a privilege.removeRole() ? In which case, I guess it would be included in the same transaction.. - Arun Suresh On June 13, 2014, 8:50 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22550/ > ----------------------------------------------------------- > > (Updated June 13, 2014, 8:50 a.m.) > > > Review request for sentry, Arun Suresh and Sravya Tirukkovalur. > > > Bugs: SENTRY-162 > https://issues.apache.org/jira/browse/SENTRY-162 > > > Repository: sentry > > > Description > ------- > > Sentry store supports a new method to drop the privileges and role mapping > for given Authorizable object. > The new API is exposed over thrift and implemented in sentry service and > client > Metastore post even hook call this API to remove the privileges related to > object being dropped > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java > 6679193 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 91669d6 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > 15a2e43 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > 097056b > > sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift > 86ff221 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 35ba83a > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java > 0165806 > > Diff: https://reviews.apache.org/r/22550/diff/ > > > Testing > ------- > > Added unit tests and E2E tests. > > > Thanks, > > Prasad Mujumdar > >
