-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22550/
-----------------------------------------------------------
(Updated June 21, 2014, 9:20 a.m.)
Review request for sentry, Arun Suresh and Sravya Tirukkovalur.
Changes
-------
- It turns out that we need to set the action in TPrivilege before after 281
and 303 patches. Updated that
- Fixed an issue in 281 patches related to determining DB privilege. That was
causing an overlap privilege test case to fail
- Updated new test case to add missing role definitions
TestSentryStore test passes with that updated patch.
Bugs: SENTRY-162
https://issues.apache.org/jira/browse/SENTRY-162
Repository: sentry
Description
-------
Sentry store supports a new method to drop the privileges and role mapping for
given Authorizable object.
The new API is exposed over thrift and implemented in sentry service and client
Metastore post even hook call this API to remove the privileges related to
object being dropped
Diffs (updated)
-----
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java
c126743
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java
PRE-CREATION
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java
6679193
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java
cf381e5
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java
2db73c6
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java
724dfa9
sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift
86ff221
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java
144e20e
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbPrivilegeCleanupOnDrop.java
PRE-CREATION
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java
fd969a6
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestExportImportPrivileges.java
b6c985e
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/hiveserver/HiveServerFactory.java
0165806
Diff: https://reviews.apache.org/r/22550/diff/
Testing
-------
Added unit tests and E2E tests.
Thanks,
Prasad Mujumdar
