----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23786/#review48363 -----------------------------------------------------------
Xiomeng, thank you for working on this patch !! Along with my other comments, I was wondering if you could remove the dependency of "PRIVILEGE_NAME" from your solution. Since the field itself is just a composite of Server, Db, Table, URI and action. This can be modeled as a aggregate key. Please take a look at SENTRY-339 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java <https://reviews.apache.org/r/23786/#comment84917> grantOption can be a Boolean i guess sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.4.0.sql <https://reviews.apache.org/r/23786/#comment84914> Any particular reason you need "WITH_GRANT_OPTION" as part of your index ? sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.4.0.sql <https://reviews.apache.org/r/23786/#comment84916> Can we use BIT/BOOLEAN datatype since this value is either 0 or 1 - Arun Suresh On July 22, 2014, 6:29 a.m., Xiaomeng Huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23786/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 6:29 a.m.) > > > Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > This is database design and implement to support "with grant option". > Add a field grantOption(int) to table SENTRY_DB_PRIVILEGE. > And modify the table SENTRY_DB_PRIVILEGE from a single index {privilegeName} > to a composite index with member {privilegeName, grantOption} > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java > f8491db > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > 945227e > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.4.0.sql > f2a62d2 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.4.0.sql > f2a62d2 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.4.0.sql > 70f4dbb > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.4.0.sql > 363590e > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.4.0.sql > 5dfae03 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 7637376 > > Diff: https://reviews.apache.org/r/23786/diff/ > > > Testing > ------- > > > Thanks, > > Xiaomeng Huang > >
