----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23786/#review48558 -----------------------------------------------------------
Thanks for the patch Xiaomeng! Mostly looks good to me. Few comments: 1. You may have to rebase it on Sentry-339 after unique key constraint has been added. 2. I am not completely sure if we require int for grant_option. More detailed comment on SENTRY-345 RB. - Sravya Tirukkovalur On July 22, 2014, 6:29 a.m., Xiaomeng Huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23786/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 6:29 a.m.) > > > Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > This is database design and implement to support "with grant option". > Add a field grantOption(int) to table SENTRY_DB_PRIVILEGE. > And modify the table SENTRY_DB_PRIVILEGE from a single index {privilegeName} > to a composite index with member {privilegeName, grantOption} > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java > f8491db > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/package.jdo > 945227e > sentry-provider/sentry-provider-db/src/main/resources/sentry-db2-1.4.0.sql > f2a62d2 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-derby-1.4.0.sql > f2a62d2 > > sentry-provider/sentry-provider-db/src/main/resources/sentry-mysql-1.4.0.sql > 70f4dbb > > sentry-provider/sentry-provider-db/src/main/resources/sentry-oracle-1.4.0.sql > 363590e > > sentry-provider/sentry-provider-db/src/main/resources/sentry-postgres-1.4.0.sql > 5dfae03 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 7637376 > > Diff: https://reviews.apache.org/r/23786/diff/ > > > Testing > ------- > > > Thanks, > > Xiaomeng Huang > >
