----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25799/#review53901 -----------------------------------------------------------
bin/config_tool <https://reviews.apache.org/r/25799/#comment93767> Curious - is there something special about exit code 5? bin/sentry <https://reviews.apache.org/r/25799/#comment93765> Maybe make this a binary (RUN_CONFIG_TOOL=0/1) rather than a string y/n. bin/sentry <https://reviews.apache.org/r/25799/#comment93768> this code of setting up the classpath and the CMD_JAR can get pushed inside the if block since you also do this in the config_tool script. - Lenni Kuff On Sept. 18, 2014, 11 p.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25799/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 11 p.m.) > > > Review request for sentry, Lenni Kuff and Sravya Tirukkovalur. > > > Bugs: SENTRY-430 > https://issues.apache.org/jira/browse/SENTRY-430 > > > Repository: sentry > > > Description > ------- > > Separate out the config-tool into a separate script. This way the core sentry > options don't need any dependancy on Hive. > > > Diffs > ----- > > bin/config_tool PRE-CREATION > bin/sentry 2990ef4 > > Diff: https://reviews.apache.org/r/25799/diff/ > > > Testing > ------- > > Manually tested various Sentry script option with the patch > > > Thanks, > > Prasad Mujumdar > >
