> On Sept. 19, 2014, 12:14 a.m., Lenni Kuff wrote: > > bin/config_tool, line 45 > > <https://reviews.apache.org/r/25799/diff/1/?file=694117#file694117line45> > > > > Curious - is there something special about exit code 5?
Not really. The existing Sentry script had exit code till 3, so just something higer .. :) > On Sept. 19, 2014, 12:14 a.m., Lenni Kuff wrote: > > bin/sentry, line 20 > > <https://reviews.apache.org/r/25799/diff/1/?file=694118#file694118line20> > > > > Maybe make this a binary (RUN_CONFIG_TOOL=0/1) rather than a string y/n. sure. will change > On Sept. 19, 2014, 12:14 a.m., Lenni Kuff wrote: > > bin/sentry, line 70 > > <https://reviews.apache.org/r/25799/diff/1/?file=694118#file694118line70> > > > > this code of setting up the classpath and the CMD_JAR can get pushed > > inside the if block since you also do this in the config_tool script. Removed it from config-tool and export CMD_JAR in sentry script. - Prasad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25799/#review53901 ----------------------------------------------------------- On Sept. 18, 2014, 11 p.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25799/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2014, 11 p.m.) > > > Review request for sentry, Lenni Kuff and Sravya Tirukkovalur. > > > Bugs: SENTRY-430 > https://issues.apache.org/jira/browse/SENTRY-430 > > > Repository: sentry > > > Description > ------- > > Separate out the config-tool into a separate script. This way the core sentry > options don't need any dependancy on Hive. > > > Diffs > ----- > > bin/config_tool PRE-CREATION > bin/sentry 2990ef4 > > Diff: https://reviews.apache.org/r/25799/diff/ > > > Testing > ------- > > Manually tested various Sentry script option with the patch > > > Thanks, > > Prasad Mujumdar > >
