----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25817/#review54151 -----------------------------------------------------------
Thanks for the patch Prasad! Minor comments below. sentry-tests/sentry-tests-hive/pom.xml <https://reviews.apache.org/r/25817/#comment94147> We need to add this test to cluster-hadoop-provider-db profile instead. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java <https://reviews.apache.org/r/25817/#comment94148> Looks like we are not using policyFile, get rid of it? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java <https://reviews.apache.org/r/25817/#comment94149> Same as above sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java <https://reviews.apache.org/r/25817/#comment94154> We may need to add "with grant" auth statements to TestDbSentryOnFailureHookLoading to make sure these failed statements are being invoking the hook as we are removing that check here. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java <https://reviews.apache.org/r/25817/#comment94150> Nit: Remove commented out code? - Sravya Tirukkovalur On Sept. 20, 2014, 1 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25817/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2014, 1 a.m.) > > > Review request for sentry and Sravya Tirukkovalur. > > > Bugs: SENTRY-383 > https://issues.apache.org/jira/browse/SENTRY-383 > > > Repository: sentry > > > Description > ------- > > Add TestPrivilegeWithGrantOption to cluster test profile. Updated the test to > extend AbstractTestWithStaticConfiguration so that it can be run in cluster > mode. Added another test case to verify implied privileges. > > > Diffs > ----- > > sentry-tests/sentry-tests-hive/pom.xml 067d1ab > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java > 7cd667e > > Diff: https://reviews.apache.org/r/25817/diff/ > > > Testing > ------- > > Added new testcase in TestPrivilegeWithGrantOption. > > > Thanks, > > Prasad Mujumdar > >
