> On Sept. 22, 2014, 6:31 p.m., Sravya Tirukkovalur wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java, > > line 58 > > <https://reviews.apache.org/r/25817/diff/2/?file=698525#file698525line58> > > > > We may need to add "with grant" auth statements to > > TestDbSentryOnFailureHookLoading to make sure these failed statements are > > being invoking the hook as we are removing that check here.
That's a valid point. I will refactor the patch to execute the hook check only for internal HS2. That way we can test the failure hook with non-cluster test. - Prasad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25817/#review54151 ----------------------------------------------------------- On Sept. 20, 2014, 1 a.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25817/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2014, 1 a.m.) > > > Review request for sentry and Sravya Tirukkovalur. > > > Bugs: SENTRY-383 > https://issues.apache.org/jira/browse/SENTRY-383 > > > Repository: sentry > > > Description > ------- > > Add TestPrivilegeWithGrantOption to cluster test profile. Updated the test to > extend AbstractTestWithStaticConfiguration so that it can be run in cluster > mode. Added another test case to verify implied privileges. > > > Diffs > ----- > > sentry-tests/sentry-tests-hive/pom.xml 067d1ab > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestPrivilegeWithGrantOption.java > 7cd667e > > Diff: https://reviews.apache.org/r/25817/diff/ > > > Testing > ------- > > Added new testcase in TestPrivilegeWithGrantOption. > > > Thanks, > > Prasad Mujumdar > >
