----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27161/#review58406 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java <https://reviews.apache.org/r/27161/#comment99404> We should reject any request that is from a non-admin user. see create_sentry_role for an example. This basically means calling: authorize(request.getRequestorUserName(), getRequestorGroups(request.getRequestorUserName()); It would also be good to add a test for this. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java <https://reviews.apache.org/r/27161/#comment99406> Is case sensitivity important? nit: ".. for security reasons" seems a bit reduant. sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift <https://reviews.apache.org/r/27161/#comment99403> We should also add the field: "required string requestorUserName" see previous comment. - Lenni Kuff On Oct. 24, 2014, 8:55 p.m., Mike Yoder wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27161/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2014, 8:55 p.m.) > > > Review request for sentry and Lenni Kuff. > > > Bugs: SENTRY-415 > https://issues.apache.org/jira/browse/SENTRY-415 > > > Repository: sentry > > > Description > ------- > > Add API to Sentry Service that allows clients to read the service's config > values. > > A new RPC was added to sentry_policy_service.thrift, thrift code rebuilt, and > new files added as a result. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/SentryPolicyService.java > d112871 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryConfigValueRequest.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryConfigValueResponse.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > 65905f5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > b54e12e > > sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift > d9a3913 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java > ff6cff4 > > Diff: https://reviews.apache.org/r/27161/diff/ > > > Testing > ------- > > Unit tests added and run successfully. > > > Thanks, > > Mike Yoder > >
