> On Oct. 24, 2014, 10:34 p.m., Lenni Kuff wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java, > > line 610 > > <https://reviews.apache.org/r/27161/diff/1/?file=732736#file732736line610> > > > > Is case sensitivity important? > > > > nit: ".. for security reasons" seems a bit reduant.
Case sensitivity... I don't *think* so. The Configuration values are case sensitive, and I've only ever seen lowercase names. And the keytab is always named keytab, and the names all start with lowercase 'sentry'. I removed "for security reasons" - Mike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27161/#review58406 ----------------------------------------------------------- On Oct. 27, 2014, 6:17 p.m., Mike Yoder wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27161/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 6:17 p.m.) > > > Review request for sentry and Lenni Kuff. > > > Bugs: SENTRY-415 > https://issues.apache.org/jira/browse/SENTRY-415 > > > Repository: sentry > > > Description > ------- > > Add API to Sentry Service that allows clients to read the service's config > values. > > A new RPC was added to sentry_policy_service.thrift, thrift code rebuilt, and > new files added as a result. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/SentryPolicyService.java > d112871 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryConfigValueRequest.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryConfigValueResponse.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyServiceClient.java > 65905f5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/SentryPolicyStoreProcessor.java > b54e12e > > sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift > d9a3913 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/thrift/TestSentryServiceIntegration.java > ff6cff4 > > Diff: https://reviews.apache.org/r/27161/diff/ > > > Testing > ------- > > Unit tests added and run successfully. > > > Thanks, > > Mike Yoder > >
