On Dec 1, 2014 5:44 PM, "Gregory Chanan" <[email protected]> wrote: > > +1. > > What's the purpose of the "Reviewed by" given we could find that > information on the JIRA?
Good point. I'm fine dropping the "Reviewed By" suffix as well. > > Greg > > On Mon, Dec 1, 2014 at 5:34 PM, Lenni Kuff <[email protected]> wrote: > > > Hi, > > I would like to propose a change in the Sentry commit process > > < > > https://cwiki.apache.org/confluence/display/SENTRY/How+to+commit#Howtocommit-Committingpatches > > >. > > Currently, the process recommends that the contributor and person who > > pushes the code change are different people, with the following > > exception: "Committers may have to bypass the long drawn process to commit > > the change in order to fix a broken build, or work through a release etc." > > > > I suggest that we relax this restriction to make it acceptable for a > > comitter to push their own change, as long as it has a +1 from another > > committer on the project. The commit messages for these changes should > > always include a new "(Reviewed by: <Name of Reviewer>)". > > > > The motivation is to improve the velocity with which changes can be > > submitted, while retaining the same level of quality for the project. > > > > Please let me know if you object to this proposed change. > > > > Thanks, > > Lenni > >
