----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26131/#review63607 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/NotificationHandler.java <https://reviews.apache.org/r/26131/#comment105878> Do you think it is possible to reuse the Existing NotificationHandler ? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/NotificationHandlerInvoker.java <https://reviews.apache.org/r/26131/#comment105879> Do you think it is possible to reuse the Existing NotificationHandlerInvoker ? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericPolicyProcessor.java <https://reviews.apache.org/r/26131/#comment105882> Can we move all operations that involve just role or group to a separate class.. so that it can also be used with SentryPolicyStoreProcessor ... and thereby reduce code duplication ? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericPolicyProcessor.java <https://reviews.apache.org/r/26131/#comment105883> Can we move all operations that involve just role or group to a separate class.. so that it can also be used with SentryPolicyStoreProcessor ... and thereby reduce code duplication ? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericPolicyProcessor.java <https://reviews.apache.org/r/26131/#comment105884> Can we move all operations that involve just role or group to a separate class.. so that it can also be used with SentryPolicyStoreProcessor ... and thereby reduce code duplication ? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericPolicyProcessor.java <https://reviews.apache.org/r/26131/#comment105885> Can we move all operations that involve just role or group to a separate class.. so that it can also be used with SentryPolicyStoreProcessor ... and thereby reduce code duplication ? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericPolicyProcessor.java <https://reviews.apache.org/r/26131/#comment105886> Can we move all operations that involve just role or group to a separate class.. so that it can also be used with SentryPolicyStoreProcessor ... and thereby reduce code duplication ? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericServiceClient.java <https://reviews.apache.org/r/26131/#comment105888> Maybe refactor this... so that it can be shared with SentryHDFSServiceClient and SentryPolicyServiceCLient.. - Arun Suresh On Sept. 29, 2014, 8:44 a.m., shen guoquan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26131/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2014, 8:44 a.m.) > > > Review request for sentry, Xiaomeng Huang, Arun Suresh, Colin Ma, Dapeng Sun, > Prasad Mujumdar, and Sravya Tirukkovalur. > > > Bugs: sentry-404 > https://issues.apache.org/jira/browse/sentry-404 > > > Repository: sentry > > > Description > ------- > > The previous thrift interface is not general and mainly fit for database > authorization model,like hive/impala. If the sentry want to binding the other > no-database authorization model such as Solr/ElasticSearch, the current > sentry service can't handle this requirement. So there is a requirement to > extend the sentry thrift interface to adapt the generic authorization model > and add a new processor to handle thrift requests. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/NotificationHandler.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/NotificationHandlerInvoker.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericPolicyProcessor.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericPolicyProcessorFactory.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/SentryGenericServiceClient.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/PolicyStoreConstants.java > 34bec93 > > sentry-provider/sentry-provider-db/src/main/resources/sentry_common_service.thrift > 9456274 > > sentry-provider/sentry-provider-db/src/main/resources/sentry_generic_policy_service.thrift > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/thrift/TestNotificationHandlerInvoker.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/thrift/TestSentryGenericPolicyProcessor.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/thrift/TestSentryGenericServiceIntegration.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/26131/diff/ > > > Testing > ------- > > > Thanks, > > shen guoquan > >
