----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26131/#review65065 -----------------------------------------------------------
Thank you for refactoring this guoquan, The code looks better now.. I understand that we had made the decision to have a separate Processor/Service/Client for the generic model.. so dont think there is any further refactoring that can be done.... but I am of the opinion that we should maybe reconsider it... for the sake of code maintainability atleast - Arun Suresh On Dec. 5, 2014, 2:18 p.m., shen guoquan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26131/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2014, 2:18 p.m.) > > > Review request for sentry, Xiaomeng Huang, Arun Suresh, Colin Ma, Dapeng Sun, > Prasad Mujumdar, and Sravya Tirukkovalur. > > > Bugs: sentry-404 > https://issues.apache.org/jira/browse/sentry-404 > > > Repository: sentry > > > Description > ------- > > The previous thrift interface is not general and mainly fit for database > authorization model,like hive/impala. If the sentry want to binding the other > no-database authorization model such as Solr/ElasticSearch, the current > sentry service can't handle this requirement. So there is a requirement to > extend the sentry thrift interface to adapt the generic authorization model > and add a new processor to handle thrift requests. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/NotificationHandler.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/NotificationHandlerInvoker.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessorFactory.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClient.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/thrift/PolicyStoreConstants.java > 34bec93 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 06aaacd > > sentry-provider/sentry-provider-db/src/main/resources/sentry_common_service.thrift > 9456274 > > sentry-provider/sentry-provider-db/src/main/resources/sentry_generic_policy_service.thrift > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericServiceIntegration.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/26131/diff/ > > > Testing > ------- > > > Thanks, > > shen guoquan > >
