----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29238/#review70173 -----------------------------------------------------------
Hi Guoquan, great work. Most original issues of mine have resolved. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SearchPolicyServiceClient.java <https://reviews.apache.org/r/29238/#comment115218> Only two issues for me, one is **synchronized**, another is **reties**. I'm agree with you that Connection Pool will help to resolve two issues, a workaround will be create a **SearchPolicyServiceClient** for every request. sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SearchProviderBackend.java <https://reviews.apache.org/r/29238/#comment115212> Have you do any test about it in kerberos? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SearchProviderBackend.java <https://reviews.apache.org/r/29238/#comment115219> Why not create a new **SearchPolicyServiceClient** for every request here - Dapeng Sun On 一月 29, 2015, 3:04 p.m., shen guoquan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29238/ > ----------------------------------------------------------- > > (Updated 一月 29, 2015, 3:04 p.m.) > > > Review request for sentry, Xiaomeng Huang, Colin Ma, Dapeng Sun, Gregory > Chanan, and Vamsee Yarlagadda. > > > Repository: sentry > > > Description > ------- > > Currently Solr does support index-level security via sentry with file as > backend privilege store. Using file as the backend store is simple, but there > has some disadvantages as followings: > 1. Can't satisfied with the needs of dynamically add, delete and update > permissions > 2. Can't be centrally managed and difficult to maintain > According to the above disadvantages, The Solr Sentry plug-in integration > with DB store is demanded. The Hive Sentry plug-in has already integration > with DB store, but the Hive authorization model is different from the Solr > authorization model.So this new feature depends on the generic authorization > model(SENTRY-398). > > > Diffs > ----- > > sentry-binding/sentry-binding-solr/pom.xml 2dfc933 > > sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchConstants.java > 7a39b79 > > sentry-policy/sentry-policy-search/src/main/java/org/apache/sentry/policy/search/SimpleSearchPolicyEngine.java > f428aea > > sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SearchPolicyServiceClient.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SearchProviderBackend.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/29238/diff/ > > > Testing > ------- > > All tests have passed through the local jenkins environment. > > > Thanks, > > shen guoquan > >
