> On March 6, 2015, 6:06 a.m., Xiaomeng Huang wrote: > > sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift, > > line 237 > > <https://reviews.apache.org/r/30267/diff/2/?file=864695#file864695line237> > > > > I just have one concern, if the privileges are very big, if > > TSentryMappingData will be out of memory?
good question, I'll do some tests to check this problem. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30267/#review75464 ----------------------------------------------------------- On Feb. 16, 2015, 3:23 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30267/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2015, 3:23 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Add new thrift interface for import/export in sentry > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/SentryPolicyService.java > c47f64a > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataRequest.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataResponse.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryImportMappingDataRequest.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryImportMappingDataResponse.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryMappingData.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift > 993ea46 > > Diff: https://reviews.apache.org/r/30267/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
