> On May 26, 2015, 10:46 p.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift, > > line 237 > > <https://reviews.apache.org/r/30267/diff/4/?file=964704#file964704line237> > > > > May be just use set<string> for groupNames? I think we should deprecate > > use of TSentryGroup struct as all it has is string field?
Thanks for the comments, the patch is updated. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30267/#review85283 ----------------------------------------------------------- On June 2, 2015, 8:37 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30267/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 8:37 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Add new thrift interface for import/export in sentry > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/SentryPolicyService.java > c47f64a > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataRequest.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryExportMappingDataResponse.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryImportMappingDataRequest.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryImportMappingDataResponse.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/service/thrift/TSentryMappingData.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/resources/sentry_policy_service.thrift > 993ea46 > > Diff: https://reviews.apache.org/r/30267/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
