> On March 6, 2015, 6:35 a.m., shen guoquan wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 2002 > > <https://reviews.apache.org/r/31070/diff/2/?file=865318#file865318line2002> > > > > Currently the order to get all mapping data for [role, privilege] is at > > firstly to get all privileges, then according to each privilege to get > > roles. I think the privilges are much more than roles in the database, why > > not reserve the order. At firstly to get all roles, then privileges
good point, I'll update the logic for this part. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31070/#review75467 ----------------------------------------------------------- On Feb. 17, 2015, 1:15 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31070/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2015, 1:15 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Update SentryStore for import/export feature > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 136dab6 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/31070/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
