----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31070/#review87973 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 2008) <https://reviews.apache.org/r/31070/#comment140379> When will roleNames be non empty? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java (line 2186) <https://reviews.apache.org/r/31070/#comment140385> Looks like the import logic is quite complex. Cant we just keep it to this? if(overwrite) { pm.newQuery(MSentryRole.class).deletePersistentAll(); pm.newQuery(MSentryPrivilege.class).deletePersistentAll(); pm.newQuery(MSentryGroup.class).deletePersistentAll(); } for(role:roles) create role if not exists for(privilege:privileges) grant privilege to role for(group:groups) for(role:group.getRoles) grant role to group Also, please comment the code more liberally. - Sravya Tirukkovalur On June 2, 2015, 8:40 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31070/ > ----------------------------------------------------------- > > (Updated June 2, 2015, 8:40 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Update SentryStore for import/export feature > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > d7937d0 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStoreImportExport.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/31070/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
