----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31073/#review75473 -----------------------------------------------------------
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryIniPolicyFileFormatter.java <https://reviews.apache.org/r/31073/#comment122537> Your source code has some redundant whitespaces sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryPolicyFileFormatter.java <https://reviews.apache.org/r/31073/#comment122536> I think change the HiveAuthzConf to Configuration is better - shen guoquan On 二月 16, 2015, 3:34 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31073/ > ----------------------------------------------------------- > > (Updated 二月 16, 2015, 3:34 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Create processor to deal with the file format for import/export feature > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryIniPolicyFileFormatter.java > PRE-CREATION > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryPolicyFileFormatFactory.java > PRE-CREATION > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryPolicyFileFormatter.java > PRE-CREATION > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java > 0a3b509 > > sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryIniPolicyFileFormatter.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/31073/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
