> On March 9, 2015, 6:02 a.m., Xiaomeng Huang wrote:
> > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryIniPolicyFileFormatter.java,
> > line 77
> > <https://reviews.apache.org/r/31073/diff/2/?file=888619#file888619line77>
> >
> > where is the left "{" of this "}"
It is formatted by eclipse, and kind of ugly, but you can find "{" in
"roles={role1=[server=server1->db=db1]".
> On March 9, 2015, 6:02 a.m., Xiaomeng Huang wrote:
> > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryIniPolicyFileFormatter.java,
> > line 108
> > <https://reviews.apache.org/r/31073/diff/2/?file=888619#file888619line108>
> >
> > Is there any advantages using Map<String, Map<String, Set<String>>>
> > rather than google Table?
This data structure will be used by thrift, and it's difficult to transfer
google Table using thrift.
- Colin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31073/#review75655
-----------------------------------------------------------
On March 9, 2015, 2:51 a.m., Colin Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31073/
> -----------------------------------------------------------
>
> (Updated March 9, 2015, 2:51 a.m.)
>
>
> Review request for sentry.
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Create processor to deal with the file format for import/export feature
>
>
> Diffs
> -----
>
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryIniPolicyFileFormatter.java
> PRE-CREATION
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryPolicyFileFormatFactory.java
> PRE-CREATION
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/SentryPolicyFileFormatter.java
> PRE-CREATION
>
> sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/conf/HiveAuthzConf.java
> 0a3b509
>
> sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestSentryIniPolicyFileFormatter.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/31073/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Colin Ma
>
>
