> On 六月 5, 2015, 2:49 a.m., Colin Ma wrote: > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestConnectorEndToEnd.java, > > line 35 > > <https://reviews.apache.org/r/35062/diff/1/?file=979007#file979007line35> > > > > For the connector, only read permission is tested? does it need to add > > test case for write permission?
Thanks colin for your question. Currently there is no sqoop command to support update connector. So it is no required > On 六月 5, 2015, 2:49 a.m., Colin Ma wrote: > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestConnectorEndToEnd.java, > > line 60 > > <https://reviews.apache.org/r/35062/diff/1/?file=979007#file979007line60> > > > > the size should be equal to the number of connector, >0 can't prove > > user3 can get all connectors. Yeah, Thanks for your advice. I will change it. > On 六月 5, 2015, 2:49 a.m., Colin Ma wrote: > > sentry-tests/sentry-tests-sqoop/pom.xml, line 138 > > <https://reviews.apache.org/r/35062/diff/1/?file=979004#file979004line138> > > > > It's a SNAPSHOT version, can we change it to a release version? Sqoop Integration test need a SQOOP-2342 feature. The latest release 1.99.6 doesn't include this feature. So it must use a trunk sqoop snapshot version - shen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35062/#review86751 ----------------------------------------------------------- On 六月 4, 2015, 10:49 a.m., shen guoquan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35062/ > ----------------------------------------------------------- > > (Updated 六月 4, 2015, 10:49 a.m.) > > > Review request for sentry, Abraham Elmahrek, Colin Ma, Dapeng Sun, Prasad > Mujumdar, and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Add e2e tests for Sqoop Sentry integration > > > Diffs > ----- > > pom.xml 8bcf1d0 > sentry-tests/pom.xml 37f0f3e > sentry-tests/sentry-tests-sqoop/pom.xml PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/AbstractSqoopSentryTestBase.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/StaticUserGroupRole.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestConnectorEndToEnd.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestGrantPrivilege.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestJobEndToEnd.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestLinkEndToEnd.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestOwnerPrivilege.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestRevokePrivilege.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestRoleOperation.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestServerScopeEndToEnd.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestShowPrivilege.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TomcatSqoopRunner.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/35062/diff/ > > > Testing > ------- > > Local environment passed > > > Thanks, > > shen guoquan > >
