----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35062/#review89109 -----------------------------------------------------------
Thinking about whether "enable link/job" and "start job" tests should exist. sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestJobEndToEnd.java (line 35) <https://reviews.apache.org/r/35062/#comment141708> I'd add the following tests: 1. deleting a job should only be allowd by folks that have "modify" privileges. sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestLinkEndToEnd.java (line 34) <https://reviews.apache.org/r/35062/#comment141707> I'd add the following tests: 1. deleting an link should be allowed to folks who have "modify" privileges - Abraham Elmahrek On June 4, 2015, 10:49 a.m., shen guoquan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35062/ > ----------------------------------------------------------- > > (Updated June 4, 2015, 10:49 a.m.) > > > Review request for sentry, Abraham Elmahrek, Colin Ma, Dapeng Sun, Prasad > Mujumdar, and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Add e2e tests for Sqoop Sentry integration > > > Diffs > ----- > > pom.xml 8bcf1d0 > sentry-tests/pom.xml 37f0f3e > sentry-tests/sentry-tests-sqoop/pom.xml PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/AbstractSqoopSentryTestBase.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/StaticUserGroupRole.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestConnectorEndToEnd.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestGrantPrivilege.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestJobEndToEnd.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestLinkEndToEnd.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestOwnerPrivilege.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestRevokePrivilege.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestRoleOperation.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestServerScopeEndToEnd.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TestShowPrivilege.java > PRE-CREATION > > sentry-tests/sentry-tests-sqoop/src/test/java/org/apache/sentry/tests/e2e/sqoop/TomcatSqoopRunner.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/35062/diff/ > > > Testing > ------- > > Local environment passed > > > Thanks, > > shen guoquan > >
