+1 for a separate branch On Tue, Jun 9, 2015 at 9:25 AM, Prasad Mujumdar <[email protected]> wrote:
> Here's my +1 for the record. > > Looks like we have a good consensus. @Dapeng, please go ahead and create a > branch for the feature. > We'll also need a jira version to track the patches going into the branch. > I can set that up in the jira. It might be a good idea to create a separate > task jira for merging this into master once the work is completed and > reviewed etc. > > thanks > Prasad > > > On Fri, Jun 5, 2015 at 1:57 AM, Shen, Guoquan <[email protected]> > wrote: > > > +1 > > > > Regards > > Guoquan > > > > -----Original Message----- > > From: Sun, Dapeng [mailto:[email protected]] > > Sent: Friday, June 05, 2015 4:51 PM > > To: [email protected] > > Subject: RE: [DISCUSS] Creating feature branch for SENTRY-498 > > > > Thank Prasad for starting this thread. > > > > +1 for creating a new branch. > > > > Regards > > Dapeng > > > > -----Original Message----- > > From: Ma, Junjie [mailto:[email protected]] > > Sent: Friday, June 05, 2015 4:42 PM > > To: [email protected] > > Subject: RE: [DISCUSS] Creating feature branch for SENTRY-498 > > > > > > There are 12 subtasks for this features, and may be more in the future. > > I'm agree to create a new branch for this. > > > > Best regards, > > > > Colin Ma(Ma Jun Jie) > > > > -----Original Message----- > > From: Prasad Mujumdar [mailto:[email protected]] > > Sent: Friday, June 5, 2015 4:36 PM > > To: dev > > Subject: [DISCUSS] Creating feature branch for SENTRY-498 > > > > Dapeng Sun is continuing the work on "SENTRY-498 : Sentry > authorization > > V2 via Hive authorization framework". Looks like this will be fairly > large > > code change of refactoring of the Hive plugin to make it work with new V2 > > auth framework in Apache Hive. We think it would be better to develop > this > > on a separate feature branch [1]. > > Please let us know if that sounds reasonable approach. > > > > [1] - [ > > > > > https://issues.apache.org/jira/browse/SENTRY-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14571970#comment-14571970 > > ] > > > > thanks > > Prasad > > > -- Sravya Tirukkovalur
