----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37067/#review94017 -----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java (line 543) <https://reviews.apache.org/r/37067/#comment148521> remove @param or comment on each parameter. update comment to something like: "Execute a query and resturn results. If getHeader is true, first item in list will contain the result set header" sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java (line 549) <https://reviews.apache.org/r/37067/#comment148520> nit: qry -> query Also, the list of lists is a bit clunky. Consider returning a new object that has a field for the results and a field for the header. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java (line 595) <https://reviews.apache.org/r/37067/#comment148523> rename to verifyResultSetColumn? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCrossDbOps.java (line 355) <https://reviews.apache.org/r/37067/#comment148522> we should probably move to a model where each test clean up everything after it finishes rahter than putting the requirement on the next test to clean up. Can address in another review. Can this go in a per-test cleanup though? - Lenni Kuff On Aug. 4, 2015, 6:44 a.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37067/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2015, 6:44 a.m.) > > > Review request for sentry. > > > Bugs: SENTRY-829 > https://issues.apache.org/jira/browse/SENTRY-829 > > > Repository: sentry > > > Description > ------- > > SENTRY-829: Fix sentry hive e2e test failures found in TestDbCrossDbOps: > create database/table first then create/grant privileges on created objects. > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 2a1c9f0 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCrossDbOps.java > 38c361c > > Diff: https://reviews.apache.org/r/37067/diff/ > > > Testing > ------- > > https://issues.apache.org/jira/browse/SENTRY-829 > > This is the first effort to clean up flaky test failures shown in 1.5.0 real > cluster test. Create sentry database/table first then create/grant privileges > on these objects. Also added many debug/log information in the test base > class to help debug flaky test furthur. > > > Thanks, > > Anne Yu > >
