----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37067/ -----------------------------------------------------------
(Updated Aug. 5, 2015, 5:03 a.m.) Review request for sentry. Changes ------- Addressed comments: 1) removed dropDb from each test, added pre-test clearAll (clear dbs and roles); 2) added a new object to store resultset from privilege query; misc others. Test done: https://builds.apache.org/job/PreCommit-SENTRY-Build/757/console Bugs: SENTRY-829 https://issues.apache.org/jira/browse/SENTRY-829 Repository: sentry Description ------- SENTRY-829: Fix sentry hive e2e test failures found in TestDbCrossDbOps: create database/table first then create/grant privileges on created objects. Diffs (updated) ----- sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java f9e8f80 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbCrossDbOps.java 719dddf sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java 2a1c9f0 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/PrivilegeResultSet.java PRE-CREATION sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCrossDbOps.java 38c361c sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUserManagement.java fa34c33 sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java 23027d1 Diff: https://reviews.apache.org/r/37067/diff/ Testing ------- https://issues.apache.org/jira/browse/SENTRY-829 This is the first effort to clean up flaky test failures shown in 1.5.0 real cluster test. Create sentry database/table first then create/grant privileges on these objects. Also added many debug/log information in the test base class to help debug flaky test furthur. Thanks, Anne Yu
