> On Aug. 6, 2015, 7:55 a.m., Colin Ma wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java, > > line 562 > > <https://reviews.apache.org/r/37155/diff/1/?file=1033081#file1033081line562> > > > > From the code, this function maybe for check if 2 lists are equal, but > > the following situation can pass the test, eg: > > excepted[a,b,c] > > returned[a,b,c,d] > > > > List can have duplicated values, maybe Set is better.
See previous comments. Because of there are uncleanup test data from previous tests, intended not to do exact equal. - Anne ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37155/#review94373 ----------------------------------------------------------- On Aug. 6, 2015, 1:25 a.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37155/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2015, 1:25 a.m.) > > > Review request for sentry and Lenni Kuff. > > > Bugs: SENTRY-834 > https://issues.apache.org/jira/browse/SENTRY-834 > > > Repository: sentry > > > Description > ------- > > Second effort to fix hive e2e test failures on a real cluster test: > TestDbConnections, TestDbExportImportPrivileges, TestDbJDBCInterface > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbConnections.java > 7024263 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbExportImportPrivileges.java > 3d67ab7 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbJDBCInterface.java > 27897f4 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbMetadataObjectRetrieval.java > 53c7d0b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 16695f5 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCrossDbOps.java > 5b1e2b8 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestExportImportPrivileges.java > b9e4da9 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestJDBCInterface.java > 6a9ae5c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestMetadataObjectRetrieval.java > fbfb031 > > Diff: https://reviews.apache.org/r/37155/diff/ > > > Testing > ------- > > https://builds.apache.org/job/PreCommit-SENTRY-Build/759/console > > > Thanks, > > Anne Yu > >
