----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37155/#review94350 -----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbConnections.java (line 75) <https://reviews.apache.org/r/37155/#comment148923> why comment out this verification? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java (line 560) <https://reviews.apache.org/r/37155/#comment148924> Explain what verification this does. Do we want to just check if the actual contains expected or should we validate that they are equal? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestExportImportPrivileges.java (line 45) <https://reviews.apache.org/r/37155/#comment148926> when would we not want to clear the db before/after the test? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestMetadataObjectRetrieval.java <https://reviews.apache.org/r/37155/#comment148925> curious - why was this causing a problem? Can you provide a bit more detail in the review description of what the actual problem is that you are fixing? - Lenni Kuff On Aug. 6, 2015, 1:25 a.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37155/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2015, 1:25 a.m.) > > > Review request for sentry and Lenni Kuff. > > > Bugs: SENTRY-834 > https://issues.apache.org/jira/browse/SENTRY-834 > > > Repository: sentry > > > Description > ------- > > Second effort to fix hive e2e test failures on a real cluster test: > TestDbConnections, TestDbExportImportPrivileges, TestDbJDBCInterface > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbConnections.java > 7024263 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbExportImportPrivileges.java > 3d67ab7 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbJDBCInterface.java > 27897f4 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbMetadataObjectRetrieval.java > 53c7d0b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 16695f5 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCrossDbOps.java > 5b1e2b8 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestExportImportPrivileges.java > b9e4da9 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestJDBCInterface.java > 6a9ae5c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestMetadataObjectRetrieval.java > fbfb031 > > Diff: https://reviews.apache.org/r/37155/diff/ > > > Testing > ------- > > https://builds.apache.org/job/PreCommit-SENTRY-Build/759/console > > > Thanks, > > Anne Yu > >
