> On Aug. 25, 2015, 11:22 p.m., Li Li wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbColumnLevelMetaDataOps.java, > > line 151 > > <https://reviews.apache.org/r/37661/diff/2/?file=1045468#file1045468line151> > > > > Shall we add some comments in jira SENTRY-846, 847, 848 and 849 to > > remove @Ignore line in this file?
Thanks for taking time reviewing the code. Will address these comments in the next cr, along with any more comments from other folks. - Anne ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37661/#review96442 ----------------------------------------------------------- On Aug. 21, 2015, 12:12 a.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37661/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2015, 12:12 a.m.) > > > Review request for sentry, Lenni Kuff and Sravya Tirukkovalur. > > > Bugs: SENTRY-742 > https://issues.apache.org/jira/browse/SENTRY-742 > > > Repository: sentry > > > Description > ------- > > Add a couple of test cases to cover column level privileges when user do > DESCRIBE, SHOW AND EXPLAIN SELECT cases. > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbColumnLevelMetaDataOps.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/PrivilegeResultSet.java > cee05a0 > > Diff: https://reviews.apache.org/r/37661/diff/ > > > Testing > ------- > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running org.apache.sentry.tests.e2e.dbprovider.TestDbColumnLevelMetaDataOps > Tests run: 6, Failures: 0, Errors: 0, Skipped: 6, Time elapsed: 17.789 sec - > in org.apache.sentry.tests.e2e.dbprovider.TestDbColumnLevelMetaDataOps > > Results : > > Tests run: 6, Failures: 0, Errors: 0, Skipped: 6 > > > Thanks, > > Anne Yu > >
