----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37661/#review99827 -----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbColumnLevelMetaDataOps.java (line 169) <https://reviews.apache.org/r/37661/#comment156803> From validateColumnMetaDataWithPatterns, Connection conneciton = context.createConnection(USER1_1); .... sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbColumnLevelMetaDataOps.java (line 189) <https://reviews.apache.org/r/37661/#comment156806> Will change this validation. Will also change tests to ensure, show/describe (extended/formatted) requires table level privileges. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbColumnLevelMetaDataOps.java (line 256) <https://reviews.apache.org/r/37661/#comment156807> Test alter...add a new column and grant privilge on table, it works fine. So it's called newCol. - Anne Yu On Aug. 26, 2015, 10:07 p.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37661/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 10:07 p.m.) > > > Review request for sentry, Lenni Kuff and Sravya Tirukkovalur. > > > Bugs: SENTRY-742 > https://issues.apache.org/jira/browse/SENTRY-742 > > > Repository: sentry > > > Description > ------- > > Add a couple of test cases to cover column level privileges when user do > DESCRIBE, SHOW AND EXPLAIN SELECT cases. > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbColumnLevelMetaDataOps.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/PrivilegeResultSet.java > cee05a0 > > Diff: https://reviews.apache.org/r/37661/diff/ > > > Testing > ------- > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Running org.apache.sentry.tests.e2e.dbprovider.TestDbColumnLevelMetaDataOps > Tests run: 6, Failures: 0, Errors: 0, Skipped: 6, Time elapsed: 17.789 sec - > in org.apache.sentry.tests.e2e.dbprovider.TestDbColumnLevelMetaDataOps > > Results : > > Tests run: 6, Failures: 0, Errors: 0, Skipped: 6 > > > Thanks, > > Anne Yu > >
