-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39228/#review103524
-----------------------------------------------------------



sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SimpleDBProviderBackend.java
 (line 75)
<https://reviews.apache.org/r/39228/#comment161572>

    There is a corner case:
    What if retryCount == Integer.MAX_VALUE?
    I know it is very very wield, but it is possible since you never know how 
user set it in conf.


- Li Li


On Oct. 21, 2015, 11:56 a.m., Yibing Shi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39228/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 11:56 a.m.)
> 
> 
> Review request for sentry and Sravya Tirukkovalur.
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> SENTRY-902: SimpleDBProviderBackend should retry the authrization process 
> properly
> 
> 
> Diffs
> -----
> 
>   
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SimpleDBProviderBackend.java
>  191e099 
> 
> Diff: https://reviews.apache.org/r/39228/diff/
> 
> 
> Testing
> -------
> 
> Test on a local cluster to make sure this retrying logic works.
> 
> 
> Thanks,
> 
> Yibing Shi
> 
>

Reply via email to