> On Oct. 22, 2015, 4:45 a.m., Li Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SimpleDBProviderBackend.java, > > line 75 > > <https://reviews.apache.org/r/39228/diff/2/?file=1102352#file1102352line75> > > > > There is a corner case: > > What if retryCount == Integer.MAX_VALUE? > > I know it is very very wield, but it is possible since you never know > > how user set it in conf. > > Yibing Shi wrote: > Yes, this is possible. Thank you for pointing it out! > In this case, we will retry only once. Do you think it is acceptable?
Thanks for asking my opinion! I think it is fine. How about adding a comment for it? - Li ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39228/#review103524 ----------------------------------------------------------- On Oct. 21, 2015, 11:56 a.m., Yibing Shi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39228/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2015, 11:56 a.m.) > > > Review request for sentry and Sravya Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > SENTRY-902: SimpleDBProviderBackend should retry the authrization process > properly > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/SimpleDBProviderBackend.java > 191e099 > > Diff: https://reviews.apache.org/r/39228/diff/ > > > Testing > ------- > > Test on a local cluster to make sure this retrying logic works. > > > Thanks, > > Yibing Shi > >
