Correction: +1 Cool off 24 hours. 48 hours and 72 hours seem to be a little *too long*;
On Tue, Nov 10, 2015 at 2:21 PM, Anne Yu <[email protected]> wrote: > +1 Cool off 24 hours. 48 hours and 72 hours seem to be a little longer. > > On Tue, Nov 10, 2015 at 11:25 AM, Lenni Kuff <[email protected]> wrote: > >> Currently Sentry has not policy in place for a cool off period for commits >> (time after patch has gotten +1'ed that the change can be committed). This >> limits the opportunity other people in the community can review a change >> prior to it going in. This is particularly important since we have >> committers across many different time zones >> >> What do you all think about adding a cool-off period for all commits after >> a patch has gotten a +1? The Hive project uses 24 hours, so we could go >> with that. Could also use something longer like 48 or 72 hours. Thoughts? >> >> Thanks, >> Lenni >> > > > > -- > Thanks, > Anne > -- Thanks, Anne
