+1 cool off 48 hrs because of the weekend. Best regards,
Colin Ma(Ma Jun Jie) -----Original Message----- From: Lenni Kuff [mailto:[email protected]] Sent: Wednesday, November 11, 2015 3:25 AM To: [email protected] Subject: [DISCUSS] Cool off period for commits? Currently Sentry has not policy in place for a cool off period for commits (time after patch has gotten +1'ed that the change can be committed). This limits the opportunity other people in the community can review a change prior to it going in. This is particularly important since we have committers across many different time zones What do you all think about adding a cool-off period for all commits after a patch has gotten a +1? The Hive project uses 24 hours, so we could go with that. Could also use something longer like 48 or 72 hours. Thoughts? Thanks, Lenni
