----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40316/#review106531 -----------------------------------------------------------
sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java (line 151) <https://reviews.apache.org/r/40316/#comment165239> Put a space before comments? sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java (line 296) <https://reviews.apache.org/r/40316/#comment165248> Can we change the function name to be more intuitive? sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java (line 329) <https://reviews.apache.org/r/40316/#comment165246> Extra space. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestEndToEnd.java (line 58) <https://reviews.apache.org/r/40316/#comment165245> Changed to " ensure udf whitelist is being enforced for any users"? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestEndToEnd.java (line 134) <https://reviews.apache.org/r/40316/#comment165243> Space. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestEndToEnd.java (line 136) <https://reviews.apache.org/r/40316/#comment165244> Space. - Hao Hao On Nov. 13, 2015, 11:52 p.m., Ryan Pridgeon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40316/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2015, 11:52 p.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > SENTRY-960: Bring whitelist validation back > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > 18b8a8f > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestEndToEnd.java > 23577c2 > > Diff: https://reviews.apache.org/r/40316/diff/ > > > Testing > ------- > > Ran the code in a live cluster to confirm it works > > Added unit test. > > > Thanks, > > Ryan Pridgeon > >
