> On Nov. 14, 2015, 12:12 a.m., Hao Hao wrote: > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java, > > line 296 > > <https://reviews.apache.org/r/40316/diff/1/?file=1125512#file1125512line296> > > > > Can we change the function name to be more intuitive?
Given the nature of this function I feel the name is suitable. I have added an additional comment to explain what it is doing - Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40316/#review106531 ----------------------------------------------------------- On Nov. 14, 2015, 7:55 p.m., Ryan Pridgeon wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40316/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2015, 7:55 p.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > SENTRY-960: Bring whitelist validation back > > > Diffs > ----- > > > sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java > 18b8a8f > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestEndToEnd.java > 23577c2 > > Diff: https://reviews.apache.org/r/40316/diff/ > > > Testing > ------- > > Ran the code in a live cluster to confirm it works > > Added unit test. > > > Thanks, > > Ryan Pridgeon > >
