----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40408/#review107216 -----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestConcurrentClients.java (line 90) <https://reviews.apache.org/r/40408/#comment166229> Haohao, generally, thanks for your review. It helps the test automation. For here, forgot to replace fixed number 5 with this var. Will change. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestConcurrentClients.java (line 201) <https://reviews.apache.org/r/40408/#comment166230> numSuccess is an instance var, its setter and getter usually are called as setVarName and getVarName. So it's better we can keep the name here. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestConcurrentClients.java (line 207) <https://reviews.apache.org/r/40408/#comment166231> Yeah, will remove extra spaces here. sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestConcurrentClients.java (line 229) <https://reviews.apache.org/r/40408/#comment166234> Can make it a more meaningful descriptions, such as, "Starting test to create database, table, role and partitions." - Anne Yu On Nov. 17, 2015, 11:06 p.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40408/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2015, 11:06 p.m.) > > > Review request for sentry, Hao Hao, Li Li, Lenni Kuff, and Sravya > Tirukkovalur. > > > Bugs: SENTRY-906 > https://issues.apache.org/jira/browse/SENTRY-906 > > > Repository: sentry > > > Description > ------- > > Add concurrent jdbc and thrift client tests to ensure synchronization works > fine; > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestConcurrentClients.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > cc5daef > > Diff: https://reviews.apache.org/r/40408/diff/ > > > Testing > ------- > > I can successfully run locally this test. > > > Thanks, > > Anne Yu > >
