> On Dec. 3, 2015, 7:10 a.m., Li Li wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestConcurrentClients.java, > > line 141 > > <https://reviews.apache.org/r/40408/diff/1/?file=1128920#file1128920line141> > > > > should we move stmt.close() and connection.close() inside of finally? > > Anne Yu wrote: > Will move.
Thanks, Anne! Besides, should we finally close stmt and connection in other methods as well, eg. adminCleanUp, adminShowRole, adminGrant, createPartition, createDbTb ? - Li ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40408/#review108787 ----------------------------------------------------------- On Nov. 17, 2015, 11:06 p.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40408/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2015, 11:06 p.m.) > > > Review request for sentry, Hao Hao, Li Li, Lenni Kuff, and Sravya > Tirukkovalur. > > > Bugs: SENTRY-906 > https://issues.apache.org/jira/browse/SENTRY-906 > > > Repository: sentry > > > Description > ------- > > Add concurrent jdbc and thrift client tests to ensure synchronization works > fine; > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestConcurrentClients.java > PRE-CREATION > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > cc5daef > > Diff: https://reviews.apache.org/r/40408/diff/ > > > Testing > ------- > > I can successfully run locally this test. > > > Thanks, > > Anne Yu > >
