----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42926/#review117444 -----------------------------------------------------------
Fix it, then Ship it! sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java (lines 166 - 167) <https://reviews.apache.org/r/42926/#comment178626> This would pass even if resultset contains <rolename1,rolename1>. Can we make the check stricter? sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java (line 193) <https://reviews.apache.org/r/42926/#comment178627> Nit: to => from? - Sravya Tirukkovalur On Feb. 2, 2016, 2:46 a.m., Gregory Chanan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42926/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2016, 2:46 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Three changes: > 1) Renames --add_role_group to --add_group_role (and -arg to -agr) because > the command is to add group to role (i.e. the objects are reversed). We > should change this before it is released and we need to support backwards > compatibility. > 2) Same as 1) with --delete_role_group and -drg > 3) Implements these commands for the sentry solr shell. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellSolr.java > 15f4a26e8fbf41ee6ffbdf9644e9d50ad4e74c77 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/AddRoleToGroupCmd.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/DeleteRoleFromGroupCmd.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/ListRolesCmd.java > bad47ef4d9ec1ba5061690171551c6bd21fa53da > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentryShellCommon.java > 3b2e233d2a83d4e6e1b4498bad2e10e06d96e582 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/GrantRoleToGroupsCmd.java > 39d3591f39f314a80ea7724f66bc13c0094a54b6 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java > 354cf357dd3f74696de4d3eb49d707e980a1a641 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/tools/TestSentryShellHive.java > 3907200d7da33faa038d63593a889f05303f7c18 > > Diff: https://reviews.apache.org/r/42926/diff/ > > > Testing > ------- > > Ran the unit tests. > > > Thanks, > > Gregory Chanan > >
