----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42926/ -----------------------------------------------------------
(Updated Feb. 2, 2016, 11:10 p.m.) Review request for sentry. Changes ------- Updated according to Sravya's review. Repository: sentry Description ------- Three changes: 1) Renames --add_role_group to --add_group_role (and -arg to -agr) because the command is to add group to role (i.e. the objects are reversed). We should change this before it is released and we need to support backwards compatibility. 2) Same as 1) with --delete_role_group and -drg 3) Implements these commands for the sentry solr shell. Diffs (updated) ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/SentryShellSolr.java 8e70ab77b1c9b93e20c737bf3e1e2b3a90f45bc8 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/AddRoleToGroupCmd.java PRE-CREATION sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/DeleteRoleFromGroupCmd.java PRE-CREATION sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/tools/command/ListRolesCmd.java bad47ef4d9ec1ba5061690171551c6bd21fa53da sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/SentryShellCommon.java 3b2e233d2a83d4e6e1b4498bad2e10e06d96e582 sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/tools/command/hive/GrantRoleToGroupsCmd.java 39d3591f39f314a80ea7724f66bc13c0094a54b6 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/tools/TestSentryShellSolr.java ae56e99e170585c14810d01872511dbbce95c660 sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/tools/TestSentryShellHive.java 788392991705b5ae2408a9b062d0152463fb6478 Diff: https://reviews.apache.org/r/42926/diff/ Testing ------- Ran the unit tests. Thanks, Gregory Chanan
