> On Feb. 6, 2016, 6:22 a.m., Colin Ma wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java, > > line 426 > > <https://reviews.apache.org/r/43234/diff/1/?file=1233875#file1233875line426> > > > > Can we reuse the getPrivilegesByProvider()? > > If pass the null as groups parameter, they have the same logic.
The problem is the return value are not the same. We need the role to MSentryGMPrivilege mapping, which has been swallowed in getPrivilegesByProvider. > On Feb. 6, 2016, 6:22 a.m., Colin Ma wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 2081 > > <https://reviews.apache.org/r/43234/diff/1/?file=1233880#file1233880line2081> > > > > There is a method already there, private Set<String> > > getAllRoleNames(PersistenceManager pm). > > Wrap this as: > > > > ..... > > existRoleNames = getAllRoleNames(pm); > > ..... Will do. - Hao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43234/#review118137 ----------------------------------------------------------- On Feb. 5, 2016, 12:57 a.m., Hao Hao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43234/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2016, 12:57 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Change-Id: I679341bfd24a3653060a024799c09c9ab907bc49 > > SENTRY-993: list_sentry_privileges_by_authorizable() gone in API v2. > > Change-Id: If070e96f9c6a66f84a25f40a2bbbdcbc2de28e36 > > > Added list_sentry_privileges_by_authorizable() for generic model thrift API. > The interface will return a <Authorizables, <Role, Set<Privileges>>> mapping. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyService.java > b42159852e1a3cc14f34b106c9c60f8436d6fdd7 > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesByAuthRequest.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TListSentryPrivilegesByAuthResponse.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/gen/thrift/gen-javabean/org/apache/sentry/provider/db/generic/service/thrift/TSentryPrivilegeMap.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > e1c15fa5304b553f69ef4d7e5053d587efb92ae5 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java > c3b0be8694c746cb09797425f98578b8faef8b4a > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java > f6d73e728f04cbb2a54595dc4d7d2b78fcd02838 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericPolicyProcessor.java > 78d38473f938b1aa2b357dd858b00f833147ee5d > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/thrift/SentryGenericServiceClientDefaultImpl.java > ce5751389670e5f2de07c1664346d1c5c26a3445 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 521d945222c240552ecde7a66b35bc5baef84a41 > > sentry-provider/sentry-provider-db/src/main/resources/sentry_generic_policy_service.thrift > 91ff672ec943003460e38892fd536444596b5795 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java > 189eabb2724e4187a39b1d1341fd231b1ac928b7 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/thrift/TestSentryGenericPolicyProcessor.java > b86c6b2c1350924683c3d3ed293502d211bcde2d > > Diff: https://reviews.apache.org/r/43234/diff/ > > > Testing > ------- > > Tested in TestSentryGenericPolicyProcessor and > TestPrivilegeOperatePersistence. > > > Thanks, > > Hao Hao > >
